Correcting Allocation Dates
Moderator: Aitrus
Correcting Allocation Dates
There are 347 IFTs in the database that take effect on weekends or holidays. This is obviously incorrect and causes other bugs, such as a broken fantasyTSP account or missing allocation change markers on your FantasyTSP graph.
First I fixed the code that was allowing IFTs to be effective on weekends or holidays. The code will automatically roll the effective date forward to the next trading day *from now on*.
This bug affected IFTs as early as 2010-01-01 and as recently as 2020-06-12.
Now, I am fixing the database. The script only takes like 5 minutes. But it changed a LOT of values and it might break something. But I tested it thoroughly and I'm backing up the allocation tables first. Pretty sure this is gonna work (at least up to par with government software quality standards).
Matt
First I fixed the code that was allowing IFTs to be effective on weekends or holidays. The code will automatically roll the effective date forward to the next trading day *from now on*.
This bug affected IFTs as early as 2010-01-01 and as recently as 2020-06-12.
Now, I am fixing the database. The script only takes like 5 minutes. But it changed a LOT of values and it might break something. But I tested it thoroughly and I'm backing up the allocation tables first. Pretty sure this is gonna work (at least up to par with government software quality standards).
Matt
Owner/creator of TSPcalc.com - "Know your numbers"
Re: Correcting Allocation Dates
Oh, hell. Thanks for the heads up. Now I know to be ready to handle the flood of complaints that are no doubt about to come in.mjedlin66 wrote: (at least up to par with government software quality standards).
Seasonal Musings 2022: viewtopic.php?f=14&t=19005
Recommended Reading: http://tspcenter.com/forums/viewtopic.php?f=14&t=13474
"It's not what happens to you, but how you react to it that matters" Epictetus
Recommended Reading: http://tspcenter.com/forums/viewtopic.php?f=14&t=13474
"It's not what happens to you, but how you react to it that matters" Epictetus
Re: Correcting Allocation Dates
It's done. Here's a before and after, using cryptonite's fantasyTSP as an example.
Cryptonite had an IFT on 6/7/2020, which was a Sunday. This caused an error in his balance which i manually fixed before, but notice there was also no red marker on his graph on 6/8 showing an IFT. Now, his IFT date has been corrected to 6/8/2020.
Cryptonite had an IFT on 6/7/2020, which was a Sunday. This caused an error in his balance which i manually fixed before, but notice there was also no red marker on his graph on 6/8 showing an IFT. Now, his IFT date has been corrected to 6/8/2020.
You do not have the required permissions to view the files attached to this post.
Owner/creator of TSPcalc.com - "Know your numbers"
Re: Correcting Allocation Dates
Hi Matt...not sure if this is related but my return percentage for 6/18/2020 looks off. I am invested as 15% L2030 , 15 % F, 70 % G. For the day L2030 was -0.07%, F +0.14%, G 0.00. The combined return shows -0.01%. Just eye balling this I would have expected to have seen a slight positive return?
The actual dollar calculation in my TSP Balance Sheet By Chart Range account looks correct and shows an increase from close 6/17 to close 6/18 and matches the TSP.Gov values. However the FantasyTSP Balance Sheet By Chart Range incorrectly shows a decrease which is likely why there is a negative value for the daily return.
When I calculate the percentage from the dollars my account, the account increased was +0.012 for the day, so I think I should have seen a +0.01% increase to my return.
The actual dollar calculation in my TSP Balance Sheet By Chart Range account looks correct and shows an increase from close 6/17 to close 6/18 and matches the TSP.Gov values. However the FantasyTSP Balance Sheet By Chart Range incorrectly shows a decrease which is likely why there is a negative value for the daily return.
When I calculate the percentage from the dollars my account, the account increased was +0.012 for the day, so I think I should have seen a +0.01% increase to my return.
Re: Correcting Allocation Dates
OH SNAP!! Does this mean my December 2018 IFT that was submitted and never executed, and subsequently caused me to drop double-digits through the end-of-the year flash crash, will be fixed and my phantom loss will be erased???
Won't help with this monstrous 2020 screw-up that I'm still clawing back from
Won't help with this monstrous 2020 screw-up that I'm still clawing back from
Navig8tor
CWO4 (BOSN)
USCG, RET
CWO4 (BOSN)
USCG, RET
-
- Posts: 250
- Joined: Wed Jul 24, 2019 8:37 am
Re: Correcting Allocation Dates
Wow man, thanks for all your work on this. Y'all have a great weekend.
Re: Correcting Allocation Dates
Can you correct some of my mistakes on the real TSP site too?
Re: Correcting Allocation Dates
It doesn't look like it. I don't see a december 2018 IFT for you. It's possible it got deleted a long time ago :/Navig8tor wrote:OH SNAP!! Does this mean my December 2018 IFT that was submitted and never executed, and subsequently caused me to drop double-digits through the end-of-the year flash crash, will be fixed and my phantom loss will be erased???
Won't help with this monstrous 2020 screw-up that I'm still clawing back from
Owner/creator of TSPcalc.com - "Know your numbers"
Re: Correcting Allocation Dates
You know what, I think I have my facts wrong - I was up 13-some percent, got caught up in an ill-timed IFT sometime in mid-September 2018, rode it WAY down and back up until I was in the +5-6% range. I remember IFT'ing to the G-fund thinking, "Well, ruined my return for the year but 5% is better than being in the hole." But, in the hole is where I went because the IFT didn't cycle. Looking back at my stats, I may have actually IFT'd sometime right before or right after Thanksgiving 2018 rather than December as I originally thought.
I promise it happened - I'm sure there is a post on here somewhere in which I was griping about it. I remember it because it was the second time it happened (since I joined in 2010) and it hosed me out of a positive return FOR THE YEAR. The first time - not a big deal - KING fixed it. That one there never did get corrected.
Not a big deal - don't waste any more time looking for it. It's just a game. But - THANKS FOR CHECKING to begin with!!
Oh yeah, there was also the time I had like a 54% return in the L-Income IN ONE DAY after I went into it for a "safety move" to beat the "G." <<< I picked up about 200 "followers" over the next couple days - they have all since departed
I promise it happened - I'm sure there is a post on here somewhere in which I was griping about it. I remember it because it was the second time it happened (since I joined in 2010) and it hosed me out of a positive return FOR THE YEAR. The first time - not a big deal - KING fixed it. That one there never did get corrected.
Not a big deal - don't waste any more time looking for it. It's just a game. But - THANKS FOR CHECKING to begin with!!
Oh yeah, there was also the time I had like a 54% return in the L-Income IN ONE DAY after I went into it for a "safety move" to beat the "G." <<< I picked up about 200 "followers" over the next couple days - they have all since departed
Navig8tor
CWO4 (BOSN)
USCG, RET
CWO4 (BOSN)
USCG, RET
Re: Correcting Allocation Dates
Do any of the recent changes explain why the 5, 15, 30, et cetera, day leader boards are all at 0.00%?
Re: Correcting Allocation Dates
Probably. Give it time.NotSoGood wrote:Do any of the recent changes explain why the 5, 15, 30, et cetera, day leader boards are all at 0.00%?
Owner/creator of TSPcalc.com - "Know your numbers"
Fund Prices2024-03-28
Fund | Price | Day | YTD |
G | $18.15 | 0.05% | 1.05% |
F | $19.08 | -0.06% | -0.74% |
C | $82.21 | 0.11% | 10.55% |
S | $82.43 | 0.30% | 6.92% |
I | $42.57 | -0.24% | 5.95% |
L2065 | $16.38 | 0.02% | 8.37% |
L2060 | $16.39 | 0.02% | 8.38% |
L2055 | $16.39 | 0.02% | 8.38% |
L2050 | $32.73 | 0.01% | 6.95% |
L2045 | $14.91 | 0.02% | 6.58% |
L2040 | $54.38 | 0.02% | 6.22% |
L2035 | $14.34 | 0.02% | 5.79% |
L2030 | $47.67 | 0.02% | 5.38% |
L2025 | $13.15 | 0.03% | 3.43% |
Linc | $25.61 | 0.03% | 2.82% |